search

pingcap / dumpling

Dumpling is a fast, easy-to-use tool written by Go for dumping data from the database(MySQL, TiDB...) to local/cloud(S3, GCP...) in multifarious formats(SQL, CSV...).
Apache License 2.0
281 stars 85 forks source link

tests: fix check diff #386

Closed Leavrth closed 3 years ago

Leavrth commented 3 years ago

What problem does this PR solve?

The new sync-diff-inspector is not compatibility with the check_diff shell.

What is changed and how it works?

remove the output directory before run sync-diff-inspector.

Related changes

Release note

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
glorv commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: 05e016203d1f76b160d46010da242192c40497ad

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #388.

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #389.

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #390.

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #391.