search

pingcap / dumpling

Dumpling is a fast, easy-to-use tool written by Go for dumping data from the database(MySQL, TiDB...) to local/cloud(S3, GCP...) in multifarious formats(SQL, CSV...).
Apache License 2.0
279 stars 85 forks source link

tests: revert #380 and #386 #392

Closed Leavrth closed 2 years ago

Leavrth commented 2 years ago

What problem does this PR solve?

380 and #386 are lock each other, need to merge them into one pr.

What is changed and how it works?

revert and merge.

Check List

Related changes

Release note

ti-chi-bot commented 2 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
glorv commented 2 years ago

/merge

ti-chi-bot commented 2 years ago

This pull request has been accepted and is ready to merge.

Commit hash: 14ecf45cc87c66c53ad0de413ec17c0160a05821

ti-chi-bot commented 2 years ago

In response to a cherrypick label: new pull request created: #393.