dumpling/gcs: fix http client credential problem

pingcap / dumpling

Dumpling is a fast, easy-to-use tool written by Go for dumping data from the database(MySQL, TiDB...) to local/cloud(S3, GCP...) in multifarious formats(SQL, CSV...).

Apache License 2.0

279 stars 85 forks source link

dumpling/gcs: fix http client credential problem #395

Closed lichunzhu closed 2 years ago

lichunzhu commented 2 years ago

What problem does this PR solve?

cherry-pick of https://github.com/pingcap/tidb/pull/29414

What is changed and how it works?

Dumpling will fail to export data to GCS because of a lack of privileges when we set our own HTTP client without specifying transport tls. This PR deletes it.

Check List

Tests

Unit test
Integration test
[x] Manual test (add detailed scripts or steps below) Test dump data with dumpling before/after this commit. Before this commit GCS will return a gcs error "google api: Error 401: anonymous caller does not have storage.object.create access to the Google Cloud Storage object.". After this commit dumpling can successfully dump data to GCS.

Related changes

Need to cherry-pick to the release branch

Release note

fix gcs http client credential problem

ti-chi-bot commented 2 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

lichunzhu commented 2 years ago

/cherry-pick release-5.2

ti-chi-bot commented 2 years ago

@lichunzhu: once the present PR merges, I will cherry-pick it on top of release-5.2 in the new PR and assign it to you.

In response to [this](https://github.com/pingcap/dumpling/pull/395#issuecomment-976239984): >/cherry-pick release-5.2 Instructions for interacting with me using PR comments are available [here](https://prow.tidb.io/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.

lichunzhu commented 2 years ago

/cherry-pick release-5.0

ti-chi-bot commented 2 years ago

@lichunzhu: once the present PR merges, I will cherry-pick it on top of release-5.0 in the new PR and assign it to you.

In response to [this](https://github.com/pingcap/dumpling/pull/395#issuecomment-976240122): >/cherry-pick release-5.0 Instructions for interacting with me using PR comments are available [here](https://prow.tidb.io/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.

lichunzhu commented 2 years ago

/merge

ti-chi-bot commented 2 years ago

This pull request has been accepted and is ready to merge.

Commit hash: 6bcd777aa4cfb87521ffcbdfd7d9c50711fe89eb

ti-chi-bot commented 2 years ago

In response to a cherrypick label: new pull request created: #396.

ti-chi-bot commented 2 years ago

In response to a cherrypick label: new pull request created: #397.