dumpling/gcs: fix http client credential problem (#395)

ti-chi-bot commented 3 years ago

This is an automated cherry-pick of #395

What problem does this PR solve?

cherry-pick of https://github.com/pingcap/tidb/pull/29414

What is changed and how it works?

Dumpling will fail to export data to GCS because of a lack of privileges when we set our own HTTP client without specifying transport tls. This PR deletes it.

Check List

Tests

Unit test
Integration test
[x] Manual test (add detailed scripts or steps below) Test dump data with dumpling before/after this commit. Before this commit GCS will return a gcs error "google api: Error 401: anonymous caller does not have storage.object.create access to the Google Cloud Storage object.". After this commit dumpling can successfully dump data to GCS.

Related changes

Need to cherry-pick to the release branch

Release note

fix gcs http client credential problem

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

lichunzhu commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: de5b84f7a2e23cc89d06759b99df9109b1e2e496

lichunzhu commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: ce39d20eae80e14d23dc69b7cf6fd5ad85df50f9

pingcap / dumpling