search

pingcap / dumpling

Dumpling is a fast, easy-to-use tool written by Go for dumping data from the database(MySQL, TiDB...) to local/cloud(S3, GCP...) in multifarious formats(SQL, CSV...).
Apache License 2.0
281 stars 85 forks source link

sql: fix pick up possible field (tidb#29399) #399

Closed lichunzhu closed 2 years ago

lichunzhu commented 2 years ago

cherry-pick https://github.com/pingcap/tidb/issues/29386 to release-5.0

What problem does this PR solve?

close https://github.com/pingcap/tidb/issues/29386 Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Fix dumpling pick up possible field function by always pick the index whose 'seqInIndex' is "1".

Check List

Tests

Release note

fix the bug that dumpling gets very slow when dumping composite primary/unique key tables.
ti-chi-bot commented 2 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
lichunzhu commented 2 years ago

/merge

ti-chi-bot commented 2 years ago

This pull request has been accepted and is ready to merge.

Commit hash: 7f237df918f1f985df2aab1d38bff63f502cb621

ti-chi-bot commented 2 years ago

In response to a cherrypick label: new pull request created: #400.

ti-chi-bot commented 2 years ago

In response to a cherrypick label: new pull request created: #401.

ti-chi-bot commented 2 years ago

In response to a cherrypick label: new pull request created: #402.