search

pingcap / failpoint

An implementation of failpoints for Golang.
Apache License 2.0
817 stars 63 forks source link

*: refactor interface to make lint happy #11

Closed lonng closed 5 years ago

lonng commented 5 years ago

Signed-off-by: Lonng chris@lonng.org

What problem does this PR solve?

Refactor Eval/EvalContext/InjectContext to make code more idiom.

What is changed and how it works?

Check List

Tests

Side effects

N/A

Related changes

N/A

lonng commented 5 years ago

PTAL @amyangfei

codecov[bot] commented 5 years ago

Codecov Report

Merging #11 into master will decrease coverage by 0.0661%. The diff coverage is 41.6666%.

@@               Coverage Diff                @@
##             master        #11        +/-   ##
================================================
- Coverage   55.4892%   55.4231%   -0.0662%     
================================================
  Files             8          8                
  Lines           838        839         +1     
================================================
  Hits            465        465                
- Misses          284        286         +2     
+ Partials         89         88         -1
lonng commented 5 years ago

also update the usage of InjectContext in README REST LGTM

OK, I will do it after https://github.com/pingcap/failpoint/pull/10 merged

lonng commented 5 years ago

PTAL again @kennytm @amyangfei