pingcap / failpoint

An implementation of failpoints for Golang.

Apache License 2.0

817 stars 63 forks source link

code: improve rewriter test coverage #20

Closed Deardrops closed 5 years ago

Deardrops commented 5 years ago

What problem does this PR solve?

Improve test coverage.

What is changed and how it works?

Improve test coverage.

Check List

Tests

Unit test

Side effects

N/A

Related changes

N/A

CLAassistant commented 5 years ago

All committers have signed the CLA.

Deardrops commented 5 years ago

~~I'm still working on improving test coverage.~~ please help me trigger the Codecov Report in this PR, thanks

lonng commented 5 years ago

@xiekeyi98 PTAL

xiekeyi98 commented 5 years ago

It seems we could see the coverage report in https://codecov.io/github/pingcap/failpoint/commit/bea37269311c3f57ec867dc11f32f8d937293f39 I'm not sure why the codecov bot does not comment in this PR.

codecov[bot] commented 5 years ago

Codecov Report

Merging #20 into master will increase coverage by 8.2838%. The diff coverage is n/a.

@@               Coverage Diff                @@
##             master        #20        +/-   ##
================================================
+ Coverage   78.6374%   86.9213%   +8.2838%     
================================================
  Files             7          7                
  Lines           866        864         -2     
================================================
+ Hits            681        751        +70     
+ Misses          109         72        -37     
+ Partials         76         41        -35

xiekeyi98 commented 5 years ago

I think may the packets loss leads to the bot comment loss, we may rerun the Travis-CI.

Deardrops commented 5 years ago

Finished, @lonng PTAL

lonng commented 5 years ago

LGTM Ping @kennytm