pingcap / failpoint

An implementation of failpoints for Golang.
Apache License 2.0
817 stars 63 forks source link

Export Failpoint/Failpoints as public types #50

Closed shafreeck closed 4 years ago

shafreeck commented 4 years ago

What problem does this PR solve?

The failpoint package is not flexible enough in use cases like

What is changed and how it works?

A proposal is available in Chinese: https://docs.google.com/document/d/1OUheSlxWkQZqIb8mLZYKE8pxlSc1YElXFutjnPQe5UE/edit?usp=sharing

Check List

Tests

Side effects

The signature of Eval is changed.

codecov[bot] commented 4 years ago

Codecov Report

Merging #50 into master will decrease coverage by 0.0015%. The diff coverage is 84.8167%.

@@               Coverage Diff                @@
##             master        #50        +/-   ##
================================================
- Coverage   85.7453%   85.7438%   -0.0016%     
================================================
  Files             7          7                
  Lines           919        968        +49     
================================================
+ Hits            788        830        +42     
- Misses           82         85         +3     
- Partials         49         53         +4     
shafreeck commented 4 years ago

@kennytm @lonng PTAL

shafreeck commented 4 years ago

@kennytm @lonng All issues have been fixed.

shafreeck commented 4 years ago

@kennytm @lonng The lock problem was fixed.