pingcap / failpoint

An implementation of failpoints for Golang.

Apache License 2.0

817 stars 63 forks source link

return err if the failpoint is not found #51

Closed w169q169 closed 4 years ago

w169q169 commented 4 years ago

What problem does this PR solve?

The failpoint block will be triggered even if failpoint name is not be enabled.

What is changed and how it works?

Return error if the failpoint is not found.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation
Need to be included in the release note

CLAassistant commented 4 years ago

All committers have signed the CLA.

codecov[bot] commented 4 years ago

Codecov Report

Merging #51 into master will increase coverage by 0.2066%. The diff coverage is 100.0000%.

@@               Coverage Diff                @@
##             master        #51        +/-   ##
================================================
+ Coverage   85.7438%   85.9504%   +0.2066%     
================================================
  Files             7          7                
  Lines           968        968                
================================================
+ Hits            830        832         +2     
+ Misses           85         84         -1     
+ Partials         53         52         -1

shafreeck commented 4 years ago

@kennytm This is a critical BUG, would you like to approve it and merge it ASAP