search

pingcap / failpoint

An implementation of failpoints for Golang.
Apache License 2.0
817 stars 63 forks source link

Why do we call `fmt.Println` in `failpoints.Eval` #65

Closed tisonkun closed 2 years ago

tisonkun commented 3 years ago

https://github.com/pingcap/failpoint/blob/7acb0f0a3dfd5accf43376f3c44d616e96b77220/failpoints.go#L272-L278

There seems no reason we do it. Either return an error or log at a proper level is reasonable.

tisonkun commented 2 years ago

Closed as no more activities.

It may be fine so we're almost enable failpoints when debugging. If someone find a real world issue, they can simply make change with that requirement.