Closed lonng closed 5 years ago
PTAL @winkyao @kennytm @amyangfei
Merging #8 into master will increase coverage by
0.8293%
. The diff coverage is70.8333%
.
@@ Coverage Diff @@
## master #8 +/- ##
================================================
+ Coverage 54.6599% 55.4892% +0.8293%
================================================
Files 8 8
Lines 794 838 +44
================================================
+ Hits 434 465 +31
- Misses 275 284 +9
- Partials 85 89 +4
I'd like to confirm, is there no way to obtain the package name during rewrite? (the github.com/pingcap/tidb
part should be obtainable from go.mod, and the ddl
part should be available from the source's package
declaration)
I'd like to confirm, is there no way to obtain the package name during rewrite? (the
github.com/pingcap/tidb
part should be obtainable from go.mod, and theddl
part should be available from the source'spackage
declaration)
We can get the github.com/pingcap/tidb
in go.mod if it exists, and get ddl
part in the package declaration. But there is not all repository use go modules.
But I can get the package path in init
function to improve performance.
But there is not all repository use go modules.
Though if the repo is not using go modules, it should be placed in $GOPATH/src/github.com/pingcap/tidb
.
Signed-off-by: Lonng chris@lonng.org
What problem does this PR solve?
Will auto extend failpoint name with package name. For example,
The name will auto extend to
github.com/pingcap/tidb/ddl/createTableErr
What is changed and how it works?
Rewrite some rules
Check List
Tests
Side effects
N/A
Related changes
N/A