add InjectCall/EnableCall to avoid test code pollute main code - Githubissues

pingcap / failpoint

An implementation of failpoints for Golang.

Apache License 2.0

817 stars 63 forks source link

add InjectCall/EnableCall to avoid test code pollute main code #83

Closed D3Hunter closed 4 months ago

D3Hunter commented 4 months ago

What problem does this PR solve?

What is changed and how it works?

with previous Inject/Enable, we you only write code inside main code, and you might need to add some special variable for test. now you can add a one line InjectCall with parameters you want to expose to test, and enable it with EnableCall, see examples/ dir for an example
InjectCall/EnableCall requires the inject 'enable' code runs within the same process as the injected code

Check List

Tests

[x] Unit test
[x] Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation
Need to be included in the release note

CLAassistant commented 4 months ago

All committers have signed the CLA.