Closed wuhuizuo closed 7 months ago
@bb7133 will @tiancaiamao be a code owner for proto/autoid.proto
? any others?
proto/recoverdatapb.proto
is also in BR domain. @wuhuizuo
raftstore related proto files: proto/disk_usage.proto proto/encryptionpb.proto proto/metapb.proto proto/raft_cmdpb.proto proto/raft_serverpb.proto proto/resource_manager.proto
@wuhuizuo Can multiple people be the owner of some files? If yes, please add @overvenus as owner as well for raftstore related proto files
@wuhuizuo Can multiple people be the owner of some files? If yes, please add @overvenus as owner as well for raftstore related proto files
Yes, I will update it.
@wuhuizuo I made some changes to the description updateing owner information, PTAL
@tonyxuqqi could you help me to solve the failure of the rust-test
CI task? It looks it deals all files include the OWNERS
file.
/cc @bb7133 @tiancaiamao @BornChanger @flowbehappy @cfzjywxk @MyonKeminta @cfzjywxk @tonyxuqqi @overvenus @niubell @you06 @lance6716 @YuJuncen
PTAL
/hold wait for more review approvals.
Can I be granted co-ownership of the brpb.proto
, cdcpb.proto
, configpb.proto
and enginepb.proto
files? I have written a significant portion of their content and understand the lessons learned from their development.
Can I be granted co-ownership of the
brpb.proto
,cdcpb.proto
,configpb.proto
andenginepb.proto
files? I have written a significant portion of their content and understand the lessons learned from their development.
PTAL
brpb.proto
cdcpb.proto
Can I be granted co-ownership of the
brpb.proto
,cdcpb.proto
,configpb.proto
andenginepb.proto
files? I have written a significant portion of their content and understand the lessons learned from their development. Sure.
proto/meta_storagepb.proto belongs to PD.
updated in https://github.com/pingcap/kvproto/pull/1231/commits/dd951a08870d53041c6388ff632ff98441a41bc7 @rleungx @overvenus @flowbehappy @BornChanger PTAL
/cc @Benjamin2037 PTAL 16101f477272b29eb1bb9a47f4a399e3183f3c2f
Ref: #1230
Why: we need control the changes of protobuf files strictly, the changes should approved by suitable teams.
proto/
folder.