pingcap / kvproto

Protocol buffer files for TiKV
Apache License 2.0
154 stars 220 forks source link

chore: add prow OWNERS file #1231

Closed wuhuizuo closed 7 months ago

wuhuizuo commented 9 months ago

Ref: #1230

Why: we need control the changes of protobuf files strictly, the changes should approved by suitable teams.

CLAassistant commented 9 months ago

CLA assistant check
All committers have signed the CLA.

wuhuizuo commented 9 months ago

@bb7133 will @tiancaiamao be a code owner for proto/autoid.proto? any others?

BornChanger commented 9 months ago

proto/recoverdatapb.proto is also in BR domain. @wuhuizuo

tonyxuqqi commented 9 months ago

raftstore related proto files: proto/disk_usage.proto proto/encryptionpb.proto proto/metapb.proto proto/raft_cmdpb.proto proto/raft_serverpb.proto proto/resource_manager.proto

tonyxuqqi commented 9 months ago

@wuhuizuo Can multiple people be the owner of some files? If yes, please add @overvenus as owner as well for raftstore related proto files

wuhuizuo commented 9 months ago

@wuhuizuo Can multiple people be the owner of some files? If yes, please add @overvenus as owner as well for raftstore related proto files

Yes, I will update it.

cfzjywxk commented 8 months ago

@wuhuizuo I made some changes to the description updateing owner information, PTAL

wuhuizuo commented 8 months ago

@tonyxuqqi could you help me to solve the failure of the rust-test CI task? It looks it deals all files include the OWNERS file.

wuhuizuo commented 8 months ago

/cc @bb7133 @tiancaiamao @BornChanger @flowbehappy @cfzjywxk @MyonKeminta @cfzjywxk @tonyxuqqi @overvenus @niubell @you06 @lance6716 @YuJuncen

PTAL

wuhuizuo commented 8 months ago

/hold wait for more review approvals.

overvenus commented 7 months ago

Can I be granted co-ownership of the brpb.proto, cdcpb.proto, configpb.proto and enginepb.proto files? I have written a significant portion of their content and understand the lessons learned from their development.

wuhuizuo commented 7 months ago

Can I be granted co-ownership of the brpb.proto, cdcpb.proto, configpb.proto and enginepb.proto files? I have written a significant portion of their content and understand the lessons learned from their development.

PTAL

BornChanger commented 7 months ago

Can I be granted co-ownership of the brpb.proto, cdcpb.proto, configpb.proto and enginepb.proto files? I have written a significant portion of their content and understand the lessons learned from their development. Sure.

rleungx commented 7 months ago

proto/meta_storagepb.proto belongs to PD.

wuhuizuo commented 7 months ago

updated in https://github.com/pingcap/kvproto/pull/1231/commits/dd951a08870d53041c6388ff632ff98441a41bc7 @rleungx @overvenus @flowbehappy @BornChanger PTAL

wuhuizuo commented 7 months ago

/cc @Benjamin2037 PTAL 16101f477272b29eb1bb9a47f4a399e3183f3c2f