pingcap / kvproto

Protocol buffer files for TiKV
Apache License 2.0
154 stars 220 forks source link

Add GetHealthFeedback RPC #1239

Closed MyonKeminta closed 6 months ago

MyonKeminta commented 7 months ago

I wonder if this is an acceptable approach... Ref: https://github.com/tikv/tikv/issues/16297

ti-chi-bot[bot] commented 6 months ago

@crazycs520: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/kvproto/pull/1239#pullrequestreview-2052159393): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, crazycs520

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/kvproto/blob/master/OWNERS)~~ [cfzjywxk] - ~~[proto/OWNERS](https://github.com/pingcap/kvproto/blob/master/proto/OWNERS)~~ [cfzjywxk] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 6 months ago

[LGTM Timeline notifier]

Timeline:

cfzjywxk commented 6 months ago

/merge