Closed YuJuncen closed 3 months ago
@3pointer: adding LGTM is restricted to approvers and reviewers in OWNERS files.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: 3pointer Once this PR has been reviewed and has the lgtm label, please assign overvenus for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
YuJuncen: Would you help me write a Pull Request description by the diff?
GitHub Copilot: Sure! Here's a concise Pull Request description based on the provided diff:
Pull Request Description
Summary
This PR introduces several new messages and fields to the
brpb.proto
file to enhance the metadata and file management capabilities.Changes
DataFileInfo
crc64xor
to store the CRC64XOR of all contents of the file.New Messages
Span
: Represents a span withoffset
andlength
.SpansOfFile
: Contains a file path and repeatedSpan
messages.LogFileSubcompactionMeta
: Metadata for log file subcompaction, including fields likesize
,region_id
,cf
,input_max_ts
,input_min_ts
,compact_from_ts
,compact_until_ts
,min_key
,max_key
,ty
, andtable_id
.LogFileSubcompaction
: ContainsLogFileSubcompactionMeta
and repeatedFile
messages.LogFileSubcompactions
: A batched version ofLogFileSubcompaction
.LogFileCompaction
: Includes fields likecompaction_from_ts
,compaction_until_ts
,name
,comments
,artifactes
,artifactes_hash
, andgenerated_files
.MetaEdit
: Contains fields for path, deletion of physical and logical files, and self-destruction flag.DeleteSpansOfFile
: An extended version ofSpansOfFile
with additional metadata for delayed deletion.Migration
: Contains repeatedMetaEdit
,truncated_to
, repeatedLogFileCompaction
, and repeateddestruct_prefix
.Motivation
These changes aim to improve the handling of file metadata, support for subcompactions, and provide more detailed information for file management and migration processes.
Feel free to adjust the description as needed!