search

pingcap / mysql-tester

A Golang implementation of MySQL Test Framework
Apache License 2.0
61 stars 62 forks source link

upgrade 1.19 #86

Closed hawkingrei closed 1 year ago

hawkingrei commented 1 year ago

upgrade to go1.19 and update all dependencies.

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

hawkingrei commented 1 year ago

BTW, I and @YangKeao try to add bazel to mysql-test. but we find it has difficult version dependencies between mysql-tester and mysql. it block the process of adding bazel into mysql-test. I hope we can move it into tidb repo.

hawkingrei commented 1 year ago

@dveeden PTAL

YangKeao commented 1 year ago

I hope we can move it into tidb repo.

I'm actually not sure whether it will bring benefit for executing mysql-test with bazel. Because the problem we faced is importing the tidb repo (but not this repo) and detect whether it has changed.

For mysql-tester, the problem can be solved through importing it directly: https://github.com/pingcap/tidb-test/blob/6a94e3aabf881ba7eb2704575ff1e2ca69908bc3/mysql_test/tools.go

hawkingrei commented 1 year ago

I hope we can move it into tidb repo.

I'm actually not sure whether it will bring benefit for executing mysql-test with bazel. Because the problem we faced is importing the tidb repo (but not this repo) and detect whether it has changed.

For mysql-tester, the problem can be solved through importing it directly: https://github.com/pingcap/tidb-test/blob/6a94e3aabf881ba7eb2704575ff1e2ca69908bc3/mysql_test/tools.go

Let me make a demo to show this.