search

pingcap / ng-monitoring

Apache License 2.0
30 stars 22 forks source link

conprof: Pass the TLS certificate to jeprof #217

Closed Connor1996 closed 9 months ago

Connor1996 commented 9 months ago

Issue Number: close #218 #219

What is changed and how it works?

Fix https://github.com/pingcap/tidb-dashboard/issues/1613

Fix it by passing the TLS certificate to jeprof.

By the way, fix some potential issues in jeprof:

mornyx commented 9 months ago

/lgtm

BTW, ngm requires a related issue. I've created and added to the description.

ti-chi-bot[bot] commented 9 months ago

[LGTM Timeline notifier]

Timeline:

ti-chi-bot[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mornyx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/ng-monitoring/blob/main/OWNERS)~~ [mornyx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mornyx commented 9 months ago

/cherry-pick release-7.5

ti-chi-bot commented 9 months ago

@mornyx: new pull request created to branch release-7.5: #224.

In response to [this](https://github.com/pingcap/ng-monitoring/pull/217#issuecomment-1864058757): >/cherry-pick release-7.5 Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.