pingcap / ng-monitoring

Apache License 2.0
31 stars 22 forks source link

conprof: use debug=1 for goroutine profile to avoid STW (#205) #229

Closed ti-chi-bot closed 10 months ago

ti-chi-bot commented 10 months ago

This is an automated cherry-pick of #205

What problem does this PR solve?

Issue Number: close #220

What is changed and how it works?

With debug=2, there are some huge STWs, which cause latency spikes in TiDB and PD.

mornyx commented 10 months ago

/lgtm

ti-chi-bot[bot] commented 10 months ago

[LGTM Timeline notifier]

Timeline:

ti-chi-bot[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mornyx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/ng-monitoring/blob/release-6.1/OWNERS)~~ [mornyx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment