search

pingcap / ng-monitoring

Apache License 2.0
31 stars 22 forks source link

*: upgrade to go1.23 #264

Closed mornyx closed 1 month ago

mornyx commented 2 months ago

What problem does this PR solve?

Issue Number: close #263

What is changed and how it works?

Upgrade to go1.23

purelind commented 2 months ago

/hold

Waiting for the test report to be completed.

mornyx commented 1 month ago

/uncc siddontang

mornyx commented 1 month ago

/cc @zhangpeijin-milo

ti-chi-bot[bot] commented 1 month ago

@mornyx: GitHub didn't allow me to request PR reviews from the following users: zhangpeijin-milo.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/pingcap/ng-monitoring/pull/264#issuecomment-2398565070): >/cc @zhangpeijin-milo Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
purelind commented 1 month ago

/lgtm

ti-chi-bot[bot] commented 1 month ago

@purelind: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/ng-monitoring/pull/264#issuecomment-2398568430): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/ng-monitoring/blob/main/OWNERS)~~ [crazycs520] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 1 month ago

[LGTM Timeline notifier]

Timeline:

mornyx commented 1 month ago

/unhold

mornyx commented 1 month ago

/merge

ti-chi-bot[bot] commented 1 month ago

@mornyx: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.