Open llk23r opened 1 year ago
For the CommitCommentEvent
, the commit_id is the commented commit, and this data is correct.
For PushEvent
, we really should extract commit_ids or commit_shas, this field will be added later, thank you for your reminder 👍
id | 22127996623
type | CommitCommentEvent
created_at | 2022-06-02 15:23:40
repo_id | 498029471
repo_name | luis-unlam/Trabajo-React-GM2-
actor_id | 35613825
actor_login | vercel[bot]
language |
additions | 0
deletions | 0
action |
number | 0
commit_id | b48fee47ee26207a358186d89a2955618c60fb2c
comment_id | 75183688
org_login |
org_id | 0
state |
closed_at | 1970-01-01 00:00:00
comments | 0
pr_merged_at | 1970-01-01 00:00:00
pr_merged | 0
pr_changed_files | 0
pr_review_comments | 0
pr_or_issue_id | 0
event_day | 2022-06-02
event_month | 2022-06-01
event_year | 2022
push_size | 0
push_distinct_size | 0
creator_user_login | vercel[bot]
creator_user_id | 35613825
pr_or_issue_created_at | 1970-01-01 00:00:00
this field will be added later
Can the existing field not be used? Why add a new field altogether and not reuse the existing field?
Assuming that CommitCommentEvent
and PushEvent
are mutually exclusive, using the same commit_id
field should be possible, assuming the rest of the fields are redundant, i.e. multiple rows with same id but different commit_id
. Looking at the schema, the id
is not-unique.
⚠️ Issue: It looks like
commit_id
is not stored properly.Query:
Response:
Blank UI:
Another example:
Query:
Response:
Possible cause:
Example Github event:
I'd assume that the commit_id be picked from
payload.commits[][sha]
but looks like it instead gets picked fromat: https://github.com/pingcap/ossinsight/blob/22356832e00106162d9516a435db398cb9cbcbb7/etl/config/initializers/fetch_event.rb#L64?