search

pingcap / parser

A MySQL Compatible SQL Parser
Apache License 2.0
1.41k stars 489 forks source link

.github: migrate ci to GitHub Actions #1247

Closed tisonkun closed 3 years ago

tisonkun commented 3 years ago

Signed-off-by: tison wander4096@gmail.com

What problem does this PR solve?

Migrate ci to GitHub Actions

What is changed and how it works?

Migrate ci to GitHub Actions

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

kennytm commented 3 years ago

should we keep the integration test? it is never passing 🤷

tisonkun commented 3 years ago

@kennytm I don't know why ITCase on CircleCI failed. But for GitHub Actions, it is because we don't have enough resource for resource-consume tests, e.g., tidbTestTopSQLSuite.TestTopSQLCPUProfile.

tisonkun commented 3 years ago

closed for now.

tisonkun commented 3 years ago

@kennytm I've skip IT case for now in GitHub Actions config due to resource limitation, but retain the code.

@zhouqiang-cl do you know how to drop circle ci integration so that we can migrate to GitHub Actions?

kennytm commented 3 years ago

@tisonkun the error is due to Circle CI still expecting a .circle.yml file. This needs to be disabled by the admin on Circle CI. Perhaps for now just keep a build-ut job which always return true.

tisonkun commented 3 years ago

@tisonkun the error is due to Circle CI still expecting a .circle.yml file. This needs to be disabled by the admin on Circle CI. Perhaps for now just keep a build-ut job which always return true.

OK. And after this pr merge we drop Circle CI and then clean the script.

tisonkun commented 3 years ago

@kennytm done.

kennytm commented 3 years ago

/lgtm

tisonkun commented 3 years ago

@kennytm would you mind to help on merging or we need another approval?

kennytm commented 3 years ago

@tisonkun we need LGT2

kennytm commented 3 years ago

@tisonkun should we cherry-pick this to release-{4.0, 5.0, 5.1}?

tisonkun commented 3 years ago

@kennytm make senses. Let me create pick PRs in the next week.

tisonkun commented 3 years ago

@kennytm created #1279 #1280 #1281 #1282 for 3.0, 4.0, 5.0 and 5.1.

I'm not sure whether or not all release branches we should pick to. May you and @zhouqiang-cl make the final decision.

kennytm commented 3 years ago

i think 5.1, 5.0, 4.0 are necessary, but 3.0 is too old to be maintained no?