pingcap / parser

A MySQL Compatible SQL Parser
Apache License 2.0
1.41k stars 489 forks source link

Model: add the new field to the Job Struct. #1273

Closed ou-bing closed 3 years ago

ou-bing commented 3 years ago

What problem does this PR solve?

Support to delete multiple indexes in one statement.

What is changed and how it works?

Add the new field to the Job Struct, I want to save some warnings when performing the change multi-schema operation.

ou-bing commented 3 years ago

@zimulala Here is the new PR for multi-schema change.

kennytm commented 3 years ago

@tisonkun should we cherry-pick this to release-{4.0, 5.0, 5.1}?

tisonkun commented 3 years ago

@kennytm I'm not the person to make decision. May @tiancaiamao and you as the leader of sql-infra conclude it.

For suggestion, I don't see even the background as an issue or other link for this PR so that it is hard to say whether pick or not.

kennytm commented 3 years ago

Sorry, wrong issue link, meant to comment on #1247 😅 @tisonkun

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
zimulala commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: c7ddd3a26df8342e9bb1d12e81905a22e57ce600

ti-chi-bot commented 3 years ago

@ou-bing: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.io/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.