*: support new placement rules syntax

pingcap / parser

A MySQL Compatible SQL Parser

Apache License 2.0

1.41k stars 489 forks source link

*: support new placement rules syntax #1299

Closed xhebox closed 3 years ago

xhebox commented 3 years ago

What problem does this PR solve?

The syntax part for pingcap/tidb#26581. One extra change: constraints is moved from unreserved to notkeywords, since mysql does not have such keyword.

Check List

Tests

Unit test
Integration test

Code changes

Has exported variable/fields change

Related changes

Need to be included in the release note

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

AilinKid
morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

AilinKid commented 3 years ago

Screenshot_20210816_172122

Kenny has some suggestions with my draft PR (in fact on your base), PTAL

xhebox commented 3 years ago

Kenny has some suggestions with my draft PR (in fact on your base), PTAL

It is already addressed.

AilinKid commented 3 years ago

sure, better make parser again to resolve the conflicts

xhebox commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: 21dce69be36d423b2896ab6d8a3695502210ba35