Added ReferencesPriv to DB and Table level, see tidb issue 26703

mjonss commented 3 years ago

What problem does this PR solve?

Parser related fix for https://github.com/pingcap/tidb/issues/26703 (ReferencesPriv needs to be on both DB/Schema and Table level).

What is changed and how it works?

In MySQL, the REFERENCES privilege can be on both DB and Table level, the Parser definition AllDBPrivs and AllTablePrivs did not include ReferencesPriv which made TiDB fail when checking it.

Check List

Tests

Manual test (add detailed scripts or steps below)
- Built TiDB with go.mod change replace github.com/pingcap/parser => ../parser to build tidb-server with the locally changed parser repository
- Tested CREATE USER r;, CREATE SCHEMA reftest;, USE reftest, CREATE TABLE t (a int);, GRANT REFERENCES ON reftest.* TO r; and GRANT REFERENCES ON reftest.t TO r; which did succeed, just like in MySQL.

Code changes

Has exported variable/fields change: AllDBPrivs and AllTablePrivs

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

kennytm
morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

mjonss commented 3 years ago

/cc @morgo Could you please review this?

xiongjiwei commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: fa902a87ce9d3b46f84ff1a74a9161d1a9511d3a

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #1363.

pingcap / parser