Closed xhebox closed 3 years ago
[REVIEW NOTIFICATION]
This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer
in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer
in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
This looks related to https://github.com/pingcap/docs/pull/6195
This looks related to pingcap/docs#6195
Yes, I was meant to update the document. But after an internal discussion, we now agreed to workaround the parser and make it a real unreserved/not-token keyword, instead of adding it to the reserved(which is not compatible with mysql).
I'll review other tokens proposed in the doc repository later.
@xhebox could you explicit @
the participants of the "internal discussion"? like After an offline discussion with @a and @b, ...
.
@xhebox could you explicit
@
the participants of the "internal discussion"? likeAfter an offline discussion with @a and @b, ...
.
It is online but in the lark. @bb7133 @djshow832
Anyway, I will merge it now.
/merge
This pull request has been accepted and is ready to merge.
Signed-off-by: xhe xw897002528@gmail.com
What problem does this PR solve?
placement
is not a keyword in mysql. Precedence is used to avoid ambiguity.Check List
Tests
Related changes