pingcap / parser

A MySQL Compatible SQL Parser
Apache License 2.0
1.41k stars 489 forks source link

move placement into not keywords #1322

Closed xhebox closed 3 years ago

xhebox commented 3 years ago

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

placement is not a keyword in mysql. Precedence is used to avoid ambiguity.

Check List

Tests

Related changes

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
dveeden commented 3 years ago

This looks related to https://github.com/pingcap/docs/pull/6195

xhebox commented 3 years ago

This looks related to pingcap/docs#6195

Yes, I was meant to update the document. But after an internal discussion, we now agreed to workaround the parser and make it a real unreserved/not-token keyword, instead of adding it to the reserved(which is not compatible with mysql).

I'll review other tokens proposed in the doc repository later.

tisonkun commented 3 years ago

@xhebox could you explicit @ the participants of the "internal discussion"? like After an offline discussion with @a and @b, ....

xhebox commented 3 years ago

@xhebox could you explicit @ the participants of the "internal discussion"? like After an offline discussion with @a and @b, ....

It is online but in the lark. @bb7133 @djshow832

Anyway, I will merge it now.

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: 47ca67b60e50b7e7ef9238d942de7518298c1d55