pingcap / parser

A MySQL Compatible SQL Parser
Apache License 2.0
1.41k stars 489 forks source link

model: move placement policy definition into parser #1327

Closed AilinKid closed 3 years ago

AilinKid commented 3 years ago

Signed-off-by: ailinkid 314806019@qq.com

What problem does this PR solve?

particial close https://github.com/pingcap/tidb/issues/26581

Since we want to store the direct placement option and policy ref into tableInfo, we better move the policyInfo and it's sub struct to parser, which will eliminate the dependency from parser ---> TiDB

What is changed and how it works?

move placement policy definition into parser

Check List

Tests

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
tangenta commented 3 years ago

What does "2 parser" mean?

xhebox commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: fa82d7db9fcab4da5b09c6f2163181390f9ae6a2

AilinKid commented 3 years ago

What does "2 parser" mean?

mistake, cleaned