search

pingcap / parser

A MySQL Compatible SQL Parser
Apache License 2.0
1.41k stars 489 forks source link

introduce a new Restore Flag RestoreBracketAroundBinaryOperation #1332

Closed qw4990 closed 3 years ago

qw4990 commented 3 years ago

What problem does this PR solve?

To fix https://github.com/pingcap/tidb/issues/27544. Now when restoring an expression, the parser doesn't add brackets for binary operations, which may change the meaning of the expression after restoring. For example, mod( year(a) - abs(weekday(a) + dayofweek(a)), 4) + 1 will be restored to YEAR(a)-ABS(WEEKDAY(a)+DAYOFWEEK(a))%4+1.

What is changed and how it works?

Introduce a new restore flag RestoreBracketAroundBinaryOperation to control this behavior.

Check List

Tests

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
xhebox commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: 448c5c318547b802e8e2414fd9a80ca0c8abc8bd