search

pingcap / parser

A MySQL Compatible SQL Parser
Apache License 2.0
1.41k stars 489 forks source link

*: support select for update of tables #1333

Closed jackysp closed 3 years ago

jackysp commented 3 years ago

Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What problem does this PR solve?

For a multi-table join, a for update stmt locks all tables, some tables may only be read-only tables that participate in it.

What is changed and how it works?

Supports the of tables syntax, which specifies that only some of the tables are locked.

Check List

Tests

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
jackysp commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: a33913e3fe480b50e95e5ae9c6fd19bfd8828690

ti-chi-bot commented 3 years ago

@jackysp: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.io/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.