search

pingcap / parser

A MySQL Compatible SQL Parser
Apache License 2.0
1.4k stars 490 forks source link

mysql/charset: add a mapping from charset ID to charset name #1336

Closed tangenta closed 3 years ago

tangenta commented 3 years ago

What problem does this PR solve?

In PR https://github.com/pingcap/tidb/pull/27875, the semantic of character_set_results == null is to return the result string encoded with the column charset.

However, the charset is represented as CharsetID(uint8), I need a function to map this ID to charset name to Lookup the corresponding Encoding struct.

What is changed and how it works?

Add a mapping from charset ID to charset name.

Check List

Tests

Code changes

None

Side effects

None

Related changes

None

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.