pingcap / parser

A MySQL Compatible SQL Parser
Apache License 2.0
1.41k stars 489 forks source link

grant `create routine`,`alter routine`,`event`,`trigger` on db.*. fix #1338

Closed jingshanglu closed 3 years ago

jingshanglu commented 3 years ago

What problem does this PR solve?

Parser related fix for https://github.com/pingcap/tidb/issues/27955 (create routine, alter routine,event,triggerneed to be on DB level).

What is changed and how it works?

In MySQL, CREATE ROUTINE,ALTER ROUTINE,EVENT,TRIGGER these privileges shoule be on DB level, and TRIGGER should be in table level,the Parser definition AllDBPrivs did not include CREATE ROUTINE,ALTER ROUTINE,EVENT,TRIGGER and AllTablePrivs did not include TRIGGER which made TiDB fail when checking it.

Check List

Tests

Code changes

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.