Closed jingshanglu closed 3 years ago
[REVIEW NOTIFICATION]
This pull request has not been approved.
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer
in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer
in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
What problem does this PR solve?
Parser related fix for https://github.com/pingcap/tidb/issues/27955 (
create routine
,alter routine
,event
,trigger
need to be on DB level).What is changed and how it works?
In MySQL,
CREATE ROUTINE
,ALTER ROUTINE
,EVENT
,TRIGGER
these privileges shoule be on DB level, andTRIGGER
should be in table level,the Parser definitionAllDBPrivs
did not includeCREATE ROUTINE
,ALTER ROUTINE
,EVENT
,TRIGGER
andAllTablePrivs
did not includeTRIGGER
which made TiDB fail when checking it.Check List
Tests
go.mod
changereplace github.com/pingcap/parser => ../parser
to build tidb-server with the locally changed parser repositorysuccessful
Code changes
AllDBPrivs
,AllTablePrivs