charset: fix Encoding.Encode() and add some tests

tangenta commented 3 years ago

What problem does this PR solve?

Required by https://github.com/pingcap/tidb/pull/27875

What is changed and how it works?

Make FindNextCharacterLength only be used in the decoding process.
Add some test for Encoding.

Check List

Tests

Unit test
Integration test

Code changes

NA

Side effects

NA

Related changes

NA

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

xiongjiwei
zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

tangenta commented 3 years ago

This PR should be merged together with pingcap/tidb#27875.

tangenta commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: 3a00a3d097341d45dc21186abcff29bb4cf49274

pingcap / parser