search

pingcap / parser

A MySQL Compatible SQL Parser
Apache License 2.0
1.41k stars 489 forks source link

Expose yySymType.Item #1346

Closed milkice233 closed 3 years ago

milkice233 commented 3 years ago

What problem does this PR solve?

Expose yySymType to global so that other packages can take advantage of Scanner.Lex() to analyze words. For example, other packages can use Lex() to judge if the string is integer, decimal, etc.

What is changed and how it works?

Add helper struct SymType and a method to copy the values from yySymType to SymType. Now code from other packages can call the Lex() in this way.

yySym := parser.NewSymType()
parser.NewScanner("123124").Lex(&yySym.YyType)
yySym.Extract()
fmt.Println(yySym.Item)  // 123124

Check List

Tests

Code changes

No existing function/variables has been changed.

Side effects

None

Related changes

None

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

milkice233 commented 3 years ago

/cc @tangenta