*: Support syntax of "CREATE/ALTER DATABASE [DEFAULT] PLACEMENT POLICY ..."

pingcap / parser

A MySQL Compatible SQL Parser

Apache License 2.0

1.41k stars 489 forks source link

*: Support syntax of "CREATE/ALTER DATABASE [DEFAULT] PLACEMENT POLICY ..." #1351

Closed sylzd closed 3 years ago

sylzd commented 3 years ago

What problem does this PR solve?

support default key word by design document
Add action for modifying schema default policy option.

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation
Need to be included in the release note

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

kennytm
morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

sylzd commented 3 years ago

@xhebox could you help to merge?

xhebox commented 3 years ago

@xhebox could you help to merge?

sure /merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: a6637fb379c36d7e280e7d54f2dd11892ca1a8cb