separate auto_increment ID from row ID

pingcap / parser

A MySQL Compatible SQL Parser

Apache License 2.0

1.41k stars 489 forks source link

separate auto_increment ID from row ID #1354

Closed tangenta closed 3 years ago

tangenta commented 3 years ago

What problem does this PR solve?

The parser part of https://github.com/pingcap/tidb/pull/28448.

What is changed and how it works?

Support syntax alter table t modify [force] row_id = xxx. This is useful in the last stage when importing with Lightning.
Add a job action ActionRebaseRowID.
Change TableInfoVersion4 to TableInfoVersion5. TableInfoVersion4 is a version that is equivalent to TableInfoVersion3 for some reasons.

Check List

Tests

Unit test
Integration test

Code changes

Side effects

Related changes

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot commented 3 years ago

@tangenta: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

tangenta commented 3 years ago

Since the parser is moved to TiDB repo, I am going to close this PR.