search

pingcap / parser

A MySQL Compatible SQL Parser
Apache License 2.0
1.41k stars 489 forks source link

add support for charset utf8mb3, utf-16, utf-32 #1362

Closed zr-hebo closed 3 years ago

zr-hebo commented 3 years ago

not support utf8mb3 charset now

add support of utf8mb3 charset

Tests

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

xiaobiao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

ti-chi-bot commented 3 years ago

Welcome @zr-hebo!

It looks like this is your first PR to pingcap/parser 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/parser. :smiley:

kennytm commented 3 years ago

Hello, thanks for the contribution.

Recently we have migrated the code back into pingcap/tidb repository as a Golang sub-module. This repository is kept for backporting fixes to older versions only. Would you mind submitting the PR to pingcap/tidb instead?

Thanks again.

zr-hebo commented 3 years ago

Hello, thanks for the contribution.

Recently we have migrated the code back into pingcap/tidb repository as a Golang sub-module. This repository is kept for backporting fixes to older versions only. Would you mind submitting the PR to pingcap/tidb instead?

Thanks again.

OK, I submit the PR to pingcap/tidb.

kennytm commented 3 years ago

(closing as this has been migrated to pingcap/tidb#28824.)