Closed ti-chi-bot closed 3 years ago
[REVIEW NOTIFICATION]
This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer
in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer
in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
This is an automated cherry-pick of #1304
What problem does this PR solve?
Parser related fix for https://github.com/pingcap/tidb/issues/26703 (ReferencesPriv needs to be on both DB/Schema and Table level).
What is changed and how it works?
In MySQL, the
REFERENCES
privilege can be on both DB and Table level, the Parser definitionAllDBPrivs
andAllTablePrivs
did not includeReferencesPriv
which made TiDB fail when checking it.Check List
Tests
go.mod
changereplace github.com/pingcap/parser => ../parser
to build tidb-server with the locally changed parser repositoryCREATE USER r;
,CREATE SCHEMA reftest;
,USE reftest
,CREATE TABLE t (a int);
,GRANT REFERENCES ON reftest.* TO r;
andGRANT REFERENCES ON reftest.t TO r;
which did succeed, just like in MySQL.Code changes
AllDBPrivs
andAllTablePrivs