search

pingcap / parser

A MySQL Compatible SQL Parser
Apache License 2.0
1.41k stars 489 forks source link

support utf8mb3 charset #1424

Open cposture opened 2 years ago

cposture commented 2 years ago

support utf8mb3 charset

refer https://dev.mysql.com/doc/refman/8.0/en/charset-charsets.html

ti-chi-bot commented 2 years ago

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

ti-chi-bot commented 2 years ago

Welcome @cposture!

It looks like this is your first PR to pingcap/parser 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/parser. :smiley:

cposture commented 2 years ago

@bb7133 please review code

dveeden commented 2 years ago

@cposture could you sign the CLA?

cposture commented 2 years ago

@cposture could you sign the CLA?

It has show "You have agreed to the CLA for pingcap/parser"

dveeden commented 2 years ago

Please have a look at https://github.com/pingcap/tidb/issues/26226 and https://github.com/pingcap/tidb/issues/31790 as they are related.

Also the parser has moved to a different repo ( https://github.com/pingcap/tidb/tree/master/parser ) as shown in the README. The reason that the pingcap/parser repo isn't archived yet is that it is still used for older versions.

cposture commented 2 years ago

Please have a look at pingcap/tidb#26226 and pingcap/tidb#31790 as they are related.

Also the parser has moved to a different repo ( https://github.com/pingcap/tidb/tree/master/parser ) as shown in the README. The reason that the pingcap/parser repo isn't archived yet is that it is still used for older versions.

ok

cposture commented 2 years ago

Please have a look at pingcap/tidb#26226 and pingcap/tidb#31790 as they are related.

Also the parser has moved to a different repo ( https://github.com/pingcap/tidb/tree/master/parser ) as shown in the README. The reason that the pingcap/parser repo isn't archived yet is that it is still used for older versions.

what should i do for https://github.com/pingcap/tidb/issues/26226？update pingcap/tidb go mod？ @dveeden

dveeden commented 2 years ago

Please have a look at pingcap/tidb#26226 and pingcap/tidb#31790 as they are related. Also the parser has moved to a different repo ( https://github.com/pingcap/tidb/tree/master/parser ) as shown in the README. The reason that the pingcap/parser repo isn't archived yet is that it is still used for older versions.

what should i do for https://github.com/pingcap/tidb/issues/26226？update pingcap/tidb go mod？ @dveeden

The first thing is to move this PR from pingcap/parser to pingcap/tidb. Then try to consider the issues I mentioned as much as possible. We now require a linked issue for PRs on pingcap/tidb, you can use one or both of these issues for that instead of creating a new one.