talent-plan/courses/rust/project[2-3]: fix the wrong compaction test - Githubissues

pingcap / talent-plan

open source training courses about distributed database and distributed systems

https://tidb.io/talent-plan

10.1k stars 1.3k forks source link

talent-plan/courses/rust/project[2-3]: fix the wrong compaction test #377

Closed yah01 closed 3 years ago

yah01 commented 3 years ago

What problem does this PR solve?

Breif description of the problem: The compaction test calculates the directory size but not considers the KvStore's writer may not sync the file buffer data into disk, so the dir_size() returns 0, what leads to the condition new_size > current_size is not satisfied, eventually this lead to pass the test. And the compaction test should test whether the open() method can calculate the uncompacted data size.

What is changed and how it works?

Check List

Tests

Manual test (add detailed scripts or steps below) Fix and then run the compaction test, and check whether the new_size is correct (greater than 0)

Side effects

Increased code complexity

yah01 commented 3 years ago

I haven't finished the project4 and project5, something wrong when I run the tests in them. Maybe I can fix them after I finish them.