drainer is not compatiable with placement rules

[lichunzhu]

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. What did you do? a. Use tiup to start a tidb cluster and use drainer to replicate to MySQL

   tiup playground v5.3.0 --monitor=false --tiflash 0 --pump 1 --drainer 1

   b. Run placement SQL in TiDB

   
   mysql> set @@global.tidb_enable_alter_placement=1;
   Query OK, 0 rows affected (0.01 sec)

mysql> CREATE PLACEMENT POLICY x1 FOLLOWERS=4; Query OK, 0 rows affected (0.18 sec)

mysql> CREATE TABLE T1 (ID INT) PLACEMENT POLICY =x1; Query OK, 0 rows affected (0.23 sec)

c. Check drainer's log.
```log
[2021/12/28 14:41:22.771 +08:00] [ERROR] [main.go:69] ["start drainer server failed"] [error="handle ddl job ID:57, Type:create placement policy, State:synced, SchemaState:public, SchemaID:1, TableID:0, RowCount:0, ArgLen:0, start time: 2021-12-28 14:41:21.591 +0800 CST, Err:<nil>, ErrCount:0, SnapshotVersion:0 failed, the schema info: {\n\t\t\"hasImplicitCol\": false,\n\t\t\"schemaMetaVersion\": 0,\n\t\t\"schemaNameToID\": {\n\t\t\t\"mysql\": 3,\n\t\t\t\"test\": 1\n\t\t},\n\t\t\"tableIDToName\": {\n\t\t\t\"11\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"tables_priv\"\n\t\t\t},\n\t\t\t\"13\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"columns_priv\"\n\t\t\t},\n\t\t\t\"15\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"GLOBAL_VARIABLES\"\n\t\t\t},\n\t\t\t\"17\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"tidb\"\n\t\t\t},\n\t\t\t\"19\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"help_topic\"\n\t\t\t},\n\t\t\t\"21\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"stats_meta\"\n\t\t\t},\n\t\t\t\"23\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"stats_histograms\"\n\t\t\t},\n\t\t\t\"25\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"stats_buckets\"\n\t\t\t},\n\t\t\t\"27\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"gc_delete_range\"\n\t\t\t},\n\t\t\t\"29\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"gc_delete_range_done\"\n\t\t\t},\n\t\t\t\"31\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"stats_feedback\"\n\t\t\t},\n\t\t\t\"33\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"role_edges\"\n\t\t\t},\n\t\t\t\"35\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"default_roles\"\n\t\t\t},\n\t\t\t\"37\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"bind_info\"\n\t\t\t},\n\t\t\t\"39\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"stats_top_n\"\n\t\t\t},\n\t\t\t\"41\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"expr_pushdown_blacklist\"\n\t\t\t},\n\t\t\t\"43\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"opt_rule_blacklist\"\n\t\t\t},\n\t\t\t\"45\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"stats_extended\"\n\t\t\t},\n\t\t\t\"47\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"schema_index_usage\"\n\t\t\t},\n\t\t\t\"49\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"stats_fm_sketch\"\n\t\t\t},\n\t\t\t\"5\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"user\"\n\t\t\t},\n\t\t\t\"51\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"global_grants\"\n\t\t\t},\n\t\t\t\"53\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"capture_plan_baselines_blacklist\"\n\t\t\t},\n\t\t\t\"55\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"column_stats_usage\"\n\t\t\t},\n\t\t\t\"7\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"global_priv\"\n\t\t\t},\n\t\t\t\"9\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"db\"\n\t\t\t}\n\t\t}\n\t}: table 0 not found"] [errorVerbose="table 0 not found\ngithub.com/pingcap/errors.NotFoundf\n\t/Users/pingcap/gopkg/pkg/mod/github.com/pingcap/errors@v0.11.5-0.20210425183316-da1aaba5fb63/juju_adaptor.go:117\ngithub.com/pingcap/tidb-binlog/drainer.(*Schema).handleDDL\n\t/Users/pingcap/workspace/optimization-build-tidb-darwin-amd/go/src/github.com/pingcap/tidb-binlog/drainer/schema.go:476\ngithub.com/pingcap/tidb-binlog/drainer.(*Schema).handlePreviousDDLJobIfNeed\n\t/Users/pingcap/workspace/optimization-build-tidb-darwin-amd/go/src/github.com/pingcap/tidb-binlog/drainer/schema.go:297\ngithub.com/pingcap/tidb-binlog/drainer.(*Syncer).run\n\t/Users/pingcap/workspace/optimization-build-tidb-darwin-amd/go/src/github.com/pingcap/tidb-binlog/drainer/syncer.go:427\ngithub.com/pingcap/tidb-binlog/drainer.(*Syncer).Start\n\t/Users/pingcap/workspace/optimization-build-tidb-darwin-amd/go/src/github.com/pingcap/tidb-binlog/drainer/syncer.go:133\ngithub.com/pingcap/tidb-binlog/drainer.(*Server).Start.func4\n\t/Users/pingcap/workspace/optimization-build-tidb-darwin-amd/go/src/github.com/pingcap/tidb-binlog/drainer/server.go:290\ngithub.com/pingcap/tidb-binlog/drainer.(*taskGroup).start.func1\n\t/Users/pingcap/workspace/optimization-build-tidb-darwin-amd/go/src/github.com/pingcap/tidb-binlog/drainer/util.go:72\nruntime.goexit\n\t/usr/local/go1.16.4/src/runtime/asm_amd64.s:1371\nhandle ddl job ID:57, Type:create placement policy, State:synced, SchemaState:public, SchemaID:1, TableID:0, RowCount:0, ArgLen:0, start time: 2021-12-28 14:41:21.591 +0800 CST, Err:<nil>, ErrCount:0, SnapshotVersion:0 failed, the schema info: {\n\t\t\"hasImplicitCol\": false,\n\t\t\"schemaMetaVersion\": 0,\n\t\t\"schemaNameToID\": {\n\t\t\t\"mysql\": 3,\n\t\t\t\"test\": 1\n\t\t},\n\t\t\"tableIDToName\": {\n\t\t\t\"11\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"tables_priv\"\n\t\t\t},\n\t\t\t\"13\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"columns_priv\"\n\t\t\t},\n\t\t\t\"15\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"GLOBAL_VARIABLES\"\n\t\t\t},\n\t\t\t\"17\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"tidb\"\n\t\t\t},\n\t\t\t\"19\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"help_topic\"\n\t\t\t},\n\t\t\t\"21\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"stats_meta\"\n\t\t\t},\n\t\t\t\"23\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"stats_histograms\"\n\t\t\t},\n\t\t\t\"25\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"stats_buckets\"\n\t\t\t},\n\t\t\t\"27\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"gc_delete_range\"\n\t\t\t},\n\t\t\t\"29\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"gc_delete_range_done\"\n\t\t\t},\n\t\t\t\"31\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"stats_feedback\"\n\t\t\t},\n\t\t\t\"33\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"role_edges\"\n\t\t\t},\n\t\t\t\"35\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"default_roles\"\n\t\t\t},\n\t\t\t\"37\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"bind_info\"\n\t\t\t},\n\t\t\t\"39\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"stats_top_n\"\n\t\t\t},\n\t\t\t\"41\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"expr_pushdown_blacklist\"\n\t\t\t},\n\t\t\t\"43\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"opt_rule_blacklist\"\n\t\t\t},\n\t\t\t\"45\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"stats_extended\"\n\t\t\t},\n\t\t\t\"47\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"schema_index_usage\"\n\t\t\t},\n\t\t\t\"49\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"stats_fm_sketch\"\n\t\t\t},\n\t\t\t\"5\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"user\"\n\t\t\t},\n\t\t\t\"51\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"global_grants\"\n\t\t\t},\n\t\t\t\"53\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"capture_plan_baselines_blacklist\"\n\t\t\t},\n\t\t\t\"55\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"column_stats_usage\"\n\t\t\t},\n\t\t\t\"7\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"global_priv\"\n\t\t\t},\n\t\t\t\"9\": {\n\t\t\t\t\"db-name\": \"mysql\",\n\t\t\t\t\"tbl-name\": \"db\"\n\t\t\t}\n\t\t}\n\t}"]

2. What did you expect to see? Drainer replicates data successfully and filter this kind of DDL correctly.

3. What did you see instead? Drainer crashed.

4. Please provide the relate downstream type and version of drainer. (run drainer -V in terminal to get drainer's version) [2021/12/28 14:39:45.047 +08:00] [INFO] [version.go:50] ["Welcome to Drainer"] ["Release Version"=v5.3.0] ["Git Commit Hash"=c032e8ba9b524a6a698475a76cc2926db17b3cad] ["Build TS"="2021-11-16 11:53:46"] ["Go Version"=go1.16.4] ["Go OS/Arch"=darwin/amd64]

[lichunzhu]

Root cause: Drainer doesn't handle create placement policy type DDL job. create placement policy has a 0 table id and goes to https://github.com/pingcap/tidb-binlog/blob/master/drainer/schema.go#L469 logic so it fails.

[amyangfei]

Have verified TiCDC doesn't have this bug, because TiCDC has a DDL allowlist, create placement policy will be ignored. ref: https://github.com/pingcap/tiflow/blob/be78431013772b41deab32ca9c1675b7d9cf1d80/pkg/filter/filter.go#L127

[lichunzhu]

A allow list looks much better than a block list. I think we can apply the same logic to drainer.