search

pingcap / tidb-binlog

A tool used to collect and merge tidb's binlog for real-time data backup and synchronization.
Apache License 2.0
292 stars 131 forks source link

Drainer should support kafka clientID property #900

Closed dixingxing0 closed 4 years ago

dixingxing0 commented 4 years ago

Feature Request

Describe the feature you'd like: Our kafka cluster is authenticate by kafka clientID, since drainer do not support clientID property, we can't push binlog data to kafka cluster. So drainer should support kafka clientID property in our scenario.

WangXiangUSTC commented 4 years ago

We can add a new configuration for Drainer, just like the kafka-version https://github.com/pingcap/tidb-binlog/blob/1239134f5437dada58de6f73025ce3fe646dc397/drainer/sync/util.go#L41

dixingxing0 commented 4 years ago

Thanks, I am working on this now, if test going well, i will submit a PR.

WangXiangUSTC commented 4 years ago

support in https://github.com/pingcap/tidb-binlog/pull/902, thanks