search

pingcap / tidb-dashboard

A Web UI for monitoring, diagnosing and managing the TiDB cluster.
https://docs.pingcap.com/tidb/stable/dashboard-intro
Apache License 2.0
176 stars 134 forks source link

Top SQL deps tracing #1037

Open shhdgit opened 2 years ago

shhdgit commented 2 years ago

We have introduced @elastic/chart in #1035. However, the latest version of @elastic/chart requires typescript version greater than v4, but currently there are problems with upgrading ts versions of react-scripts. And since react-app-rewired is no longer maintained, it is hard to upgrade react-script. (https://github.com/arackaf/customize-cra/issues/296)

So we're using @elastic/chart@^20.0.0 for now, until we replace the build toolchain.

breezewish commented 2 years ago

I have a question: Actually we are using customize-cra, not react-app-rewired. Does it solve problems? customize-cra and craco are both solving CRA 2.0 issues. I don't have ideas about their real differences, e.g. what customize-cra cannot do but craco can do.

breezewish commented 2 years ago

Another way might be adopting https://nextjs.org/. Pros: many things out of box. Cons: we no longer need to dig deeper, which is not good for personal improvements.

shhdgit commented 2 years ago

customize-cra relies on react-app-rewired. react-app-rewired has its own peer deps of react-scripts and craco can specify its own react-scripts(https://github.com/gsoft-inc/craco#support). And craco is still being maintained, react-app-rewired/customize-cra is not.

I do like the solution provided by the framework. But the framework will invade the application code, which will make app hard to migrate.