pingcap / tidb-dashboard

A Web UI for monitoring, diagnosing and managing the TiDB cluster.
https://docs.pingcap.com/tidb/stable/dashboard-intro
Apache License 2.0
176 stars 134 forks source link

add ticdc topology in apiserver #1622

Closed CharlesCheung96 closed 11 months ago

CharlesCheung96 commented 11 months ago

Manual test: image

netlify[bot] commented 11 months ago

Deploy Preview for tidb-dashboard canceled.

Name Link
Latest commit ce0561b2f3f857f1aa3d6db20b074dae81e45566
Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/657fea3ff84f7d0008eded52
CLAassistant commented 11 months ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 11 months ago

Codecov Report

Merging #1622 (ce0561b) into master (5aec71c) will decrease coverage by 0.18%. Report is 1 commits behind head on master. The diff coverage is 0.85%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1622 +/- ## ========================================== - Coverage 24.59% 24.41% -0.18% ========================================== Files 169 170 +1 Lines 15314 15430 +116 ========================================== + Hits 3766 3767 +1 - Misses 11265 11380 +115 Partials 283 283 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb-dashboard/pull/1622/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Ξ” | | |---|---|---| | [backend_integration](https://app.codecov.io/gh/pingcap/tidb-dashboard/pull/1622/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `9.20% <0.94%> (-0.03%)` | :arrow_down: | | [backend_ut](https://app.codecov.io/gh/pingcap/tidb-dashboard/pull/1622/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `26.37% <0.00%> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/pingcap/tidb-dashboard/pull/1622?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) > `Ξ” = absolute (impact)`, `ΓΈ = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/pingcap/tidb-dashboard/pull/1622?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap). Last update [f13291e...ce0561b](https://app.codecov.io/gh/pingcap/tidb-dashboard/pull/1622?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap).
baurine commented 11 months ago

Please help fix the CI error as well.

ti-chi-bot[bot] commented 11 months ago

@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tidb-dashboard/pull/1622#pullrequestreview-1782192512): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mornyx Once this PR has been reviewed and has the lgtm label, please assign crazycs520 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tidb-dashboard/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment