pingcap / tidb-dashboard

A Web UI for monitoring, diagnosing and managing the TiDB cluster.
https://docs.pingcap.com/tidb/stable/dashboard-intro
Apache License 2.0
175 stars 133 forks source link

fix(cluster_info): fix error for hosts/disks/statistics page #1664

Closed baurine closed 6 months ago

baurine commented 6 months ago

This PR fixes the following error pages:

image image image

netlify[bot] commented 6 months ago

Deploy Preview for tidb-dashboard ready!

Name Link
Latest commit 3b9def8612e030dbdc9d2d1af0ac12b267c89d56
Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/6602ac774b31c50008c5cc69
Deploy Preview https://deploy-preview-1664--tidb-dashboard.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 23.68%. Comparing base (c32ca0c) to head (3b9def8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1664 +/- ## =========================================== + Coverage 8.99% 23.68% +14.68% =========================================== Files 131 177 +46 Lines 13704 16055 +2351 =========================================== + Hits 1233 3802 +2569 + Misses 12338 11968 -370 - Partials 133 285 +152 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb-dashboard/pull/1664/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Ξ” | | |---|---|---| | [backend_integration](https://app.codecov.io/gh/pingcap/tidb-dashboard/pull/1664/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `8.98% <0.00%> (-0.01%)` | :arrow_down: | | [backend_ut](https://app.codecov.io/gh/pingcap/tidb-dashboard/pull/1664/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `26.19% <ΓΈ> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/pingcap/tidb-dashboard/pull/1664?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) > `Ξ” = absolute (impact)`, `ΓΈ = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/pingcap/tidb-dashboard/pull/1664?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap). Last update [c32ca0c...3b9def8](https://app.codecov.io/gh/pingcap/tidb-dashboard/pull/1664?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap).
ti-chi-bot[bot] commented 6 months ago

@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tidb-dashboard/pull/1664#pullrequestreview-1960154744): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mornyx Once this PR has been reviewed and has the lgtm label, please ask for approval from baurine, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tidb-dashboard/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment