restore: don't change TiDB config to support lightning via SQL

pingcap / tidb-lightning

This repository has been moved to https://github.com/pingcap/br

Apache License 2.0

143 stars 66 forks source link

restore: don't change TiDB config to support lightning via SQL #545

Closed lance6716 closed 3 years ago

lance6716 commented 3 years ago

What problem does this PR solve?

after use lightning as library, init() changed TiDB's global configuration unexpected

What is changed and how it works?

try removing usage of tidbcfg

Check List

Tests

pass original test

Side effects

Related changes

lance6716 commented 3 years ago

cc @crazycs520

ti-srebot commented 3 years ago

@breeswish, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: migrate(slack).

glorv commented 3 years ago

LGTM