upgrade k8s code to 1.16

pingcap / tidb-operator

TiDB operator creates and manages TiDB clusters running in Kubernetes.

https://docs.pingcap.com/tidb-in-kubernetes/

Apache License 2.0

1.22k stars 493 forks source link

upgrade k8s code to 1.16 #1020

Closed cofyc closed 4 years ago

cofyc commented 4 years ago

Feature Request

Is your feature request related to a problem? Please describe:

Keep up to date with the latest k8s code.

compatibility is guaranteed by CI and stability tests (tested in k8s 1.12.x), in the future, we can add more test jobs for other Kubernetes versions (https://github.com/pingcap/tidb-operator/issues/1008)
latest k8s e2e framework (k8s.io/kubernetes/test/e2e/framework) is well designed and can be reused in projects outside of core Kubernetes, we can leverage this framework to write our e2e tests
easier to adopt libraries which depends on newer k8s code

Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

cofyc commented 4 years ago

[x] rename pingcap.com to pingcap (https://github.com/pingcap/tidb-operator/pull/1061)
- the higher version of code-generator will use the name of this directory as the package name, so the domain cannot be used

yylt commented 4 years ago

the pingcap/pd not use go mod manage module at v2.1.0-beta+incompatible pd use etcd@v0.0.0-20180530235116-2b3aa7e1d49d， but k8s@1.16 use etcd@v3.3.15 , it will conflict

cofyc commented 4 years ago

yes, it's a problem, we need to upgrade PD

gregwebs commented 4 years ago

PD should not be required to align dependencies with k8s, particularly one like etcd. We just need to reference some API code that should be abstracted over PD dependencies. I think the problem is that we are referencing a PD package that imports many things. Instead the PD API definitions should be moved to a package with minimal dependencies.

cofyc commented 4 years ago

I think the problem is that we are referencing a PD package that imports many things. Instead the PD API definitions should be moved to a package with minimal dependencies.

yes, that will be better

aylei commented 4 years ago

I think the problem is that we are referencing a PD package that imports many things. Instead the PD API definitions should be moved to a package with minimal dependencies.

@gregwebs I'm working on proposing this to PD and TiDB.

@cofyc Because it takes time for PD to merge the change and release a new version, I've copied the config type definition and get rid of the pd/server dependency for now in #1048