search

pingcap / tidb-operator

TiDB operator creates and manages TiDB clusters running in Kubernetes.
https://docs.pingcap.com/tidb-in-kubernetes/
Apache License 2.0
1.22k stars 493 forks source link

setting the events BurstSize/QPS to proper values #1494

Closed weekface closed 4 years ago

weekface commented 4 years ago

Feature Request

Is your feature request related to a problem? Please describe:

https://github.com/pingcap/tidb-operator/pull/1466#discussion_r362735307

The default is a little small, we should set them to a proper values.

    // by default, allow a source to send 25 events about an object
    // but control the refill rate to 1 new event every 5 minutes
    // this helps control the long-tail of events for things that are always
    // unhealthy
    defaultSpamBurst = 25
    defaultSpamQPS   = 1. / 300.

Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

github-actions[bot] commented 4 years ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days