search

pingcap / tidb-operator

TiDB operator creates and manages TiDB clusters running in Kubernetes.
https://docs.pingcap.com/tidb-in-kubernetes/
Apache License 2.0
1.22k stars 489 forks source link

clean up: remove unused Informer().HasSynced #2599

Open zjj2wry opened 4 years ago

zjj2wry commented 4 years ago

Feature Request

Is your feature request related to a problem? Please describe:

The shared informer factory has called the WaitForCacheSync method, and it is no longer need to call it separately for each controller. We can remove Informer ().HasSynced because it will not be used.

https://github.com/pingcap/tidb-operator/blob/master/pkg/controller/tidbcluster/tidb_cluster_controller.go#L248

Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

github-actions[bot] commented 4 years ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days

drivebyer commented 1 year ago

/assign