search

pingcap / tidb-operator

TiDB operator creates and manages TiDB clusters running in Kubernetes.
https://docs.pingcap.com/tidb-in-kubernetes/
Apache License 2.0
1.22k stars 493 forks source link

Make `EvictLeaderTimeout` configurable #3334

Closed DanielZhangQD closed 3 years ago

DanielZhangQD commented 3 years ago

Feature Request

Is your feature request related to a problem? Please describe:

Currently, the EvictLeaderTimeout is hardcoded in https://github.com/pingcap/tidb-operator/blob/master/pkg/manager/member/tikv_upgrader.go#L36, it's better to make it configurable per TidbCluster because some users may have large data and want to extend the timeout value. Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

DanielZhangQD commented 3 years ago

We can set the default value to 3 Minutes as we're doing now.