search

pingcap / tidb-operator

TiDB operator creates and manages TiDB clusters running in Kubernetes.
https://docs.pingcap.com/tidb-in-kubernetes/
Apache License 2.0
1.22k stars 489 forks source link

Users want to customize tags for docker images on TiDB operator #4676

Open superlzs0476 opened 2 years ago

superlzs0476 commented 2 years ago

Feature Request

Is your feature request related to a problem? Please describe:

Because the TiDB operator will always fetch the docker image with {baseImage}:{spec.version} so today users have to set the spec.version to master-1655403302-89a8cabf otherwise user company docker repo will not find the docker image.

Example: https://github.com/pingcap/tidb-operator/blob/c77aea715b4549fda85c5df7baf33b792508b208/pkg/apis/pingcap/v1alpha1/tidbcluster.go#L55. And then spec.version is also used for checking whether users could enable some features: https://github.com/pingcap/tidb-operator/blob/master/pkg/manager/member/utils.go#L442

Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

liubog2008 commented 2 years ago

Now the image tag is also used to check tidb version for compatibility, so the image tag should be in semver format now.

superlzs0476 commented 2 years ago

From Users comment:

  1. put our customized tag master-1655403302-89a8cabf into spec.tikv.image for example ...organization_name/tikv-enterprise:master-1655403302-89a8cabf. The version here is only used for image fetching.
  2. put the real TiDB version 6.1.0 to spec.version and use it as the real version for any feature check.