pingcap / tidb-operator

TiDB operator creates and manages TiDB clusters running in Kubernetes.
https://docs.pingcap.com/tidb-in-kubernetes/
Apache License 2.0
1.23k stars 498 forks source link

Increase k8s client-go rate-limit qps #4829

Closed Thearas closed 1 year ago

Thearas commented 1 year ago

Feature Request

Is your feature request related to a problem? Please describe:

Hi, I'm from the TiDB QA team. We run hundreds of tidb in our K8s. When deploying tens of tidb at the same time, we found that deploying tidb cluster (even the smallest tc) were very slow, nearly 30m. The reason is that the k8s client-go used by the tidb operator has a QPS 5 rate-limit: tc-ratelimit

After increasing QPS, these logs above disappear and the deployment time is reduced to 5m.

Describe the feature you'd like:

Add two configurations to set QPS and Burst, e.g. kubeClientQPS and kubeClientBurst

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

csuzhangxc commented 1 year ago

👍 good suggestion.